[Bug 226412] Merge Review: setup

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226412


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
               Flag|                            |fedora-review?




--- Comment #4 from Jon Ciesla <limb at jcomserv.net>  2008-12-11 11:43:27 EDT ---
rpmlint on SRPM clean.

rpmlint on RPMS:

setup.noarch: E: non-readable /etc/securetty 0600
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

setup.noarch: E: zero-length /etc/environment
setup.noarch: E: zero-length /etc/motd
setup.noarch: E: non-readable /etc/shadow 0400
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

setup.noarch: E: non-readable /etc/gshadow 0400
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

setup.noarch: E: standard-dir-owned-by-package /etc/profile.d
This package owns a directory that is part of the standard hierarchy, which
can lead to default directory permissions or ownerships being changed to
something non-standard.

setup.noarch: E: zero-length /etc/exports
setup.noarch: W: log-files-without-logrotate /var/log/lastlog
This package contains files in /var/log/ without adding logrotate
configuration for them.

These should all be filed as rpmlint exceptions.

Page in URL is default Trac page.  Might want to look into that. :)

Source tag needs to include a URL:
https://fedoraproject.org/wiki/Packaging/SourceURL
Should also be Source0, not simply Source.

I don't see any license information in the source or the website, just the
spec.  Add something to the upstream documenting the licensing, then include it
in %doc.

Otherwise, very simple package, no other blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.