[Bug 457925] Review Request: biniax - A unique arcade logic game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457925





--- Comment #14 from Christoph Wickert <fedora at christoph-wickert.de>  2008-12-11 14:23:06 EDT ---
I think there is something that needs to fixed in the spec:

> Patch0:	%{name}-%{version}-gfx.patch
> Patch1:	%{name}-%{version}-snd.patch
> Patch2:	%{name}-%{version}-save.patch
> Patch3:	%{name}-%{version}-optflags.patch

This does not work, because during an update you will have to rename all the
patches. This also means removing and re-adding them from/to cvs. If the names
of the patches are changed one does not get the diff in the commit. 

So it needs to be:
Patch0:  %{name}-1.2-gfx.patch
...

The version in the patch name is always the version where the patch was added
but not the version of the package itself.


> Requires:	hicolor-icon-theme

This should IMO be removed. Without the icon-theme there is no icon in the
desktop file, but this does no real harm. hicolor-icon-theme is installed as
soon as gtk2 gets installed. In the very unlikely case that somebody really
does not have gtk2, he most likely doesn't have a menu ether or at least not
menu that shows icons (think of openbox or fluxbox for example).

Nevertheless none of these issues is really important enough to justify an
update, fixing in CVS is sufficient.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.