[Bug 226544] Merge Review: wpa_supplicant

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226544





--- Comment #10 from Peter Lemenkov <lemenkov at gmail.com>  2008-12-11 15:11:39 EDT ---
Remarks:

* Latest development version is 0.6.6 - consider upgrading.
* %install section needs some cleanups:
** installation should preserve timestamps (e.g. %install should be invoked
with -p key)
** no need to explicitly create directories - you should use key -D
** I don't see the need to cleanup something in
$BUILD/%{name}-%{version}/%{name}/doc/

E.g. I propose you to shorten install section up to

========================================

%install
rm -rf %{buildroot}

# init scripts
install -D -p -m 0755 %{SOURCE3}
%{buildroot}/%{_sysconfdir}/rc.d/init.d/%{name}
install -D -p -m 0644 %{SOURCE4} %{buildroot}/%{_sysconfdir}/sysconfig/%{name}
install -D -p -m 0644 %{SOURCE6}
%{buildroot}/%{_sysconfdir}/logrotate.d/%{name}

# config
install -D -p -m 0600 %{SOURCE2}
%{buildroot}/%{_sysconfdir}/%{name}/%{name}.conf

# binary
install -d %{buildroot}/%{_sbindir}
install -m 0755 %{name}/wpa_passphrase %{buildroot}/%{_sbindir}
install -m 0755 %{name}/wpa_cli %{buildroot}/%{_sbindir}
install -m 0755 %{name}/wpa_supplicant %{buildroot}/%{_sbindir}
install -D -p -m 0644 %{name}/dbus-wpa_supplicant.conf
%{buildroot}/%{_sysconfdir}/dbus-1/system.d/wpa_supplicant.conf
install -D -p -m 0644 %{name}/dbus-wpa_supplicant.service
%{buildroot}/%{_datadir}/dbus-1/system-services/fi.epitest.hostap.WPASupplicant.service

# gui
install -D -p -m 0755 %{name}/wpa_gui/wpa_gui %{buildroot}/%{_bindir}/wpa_gui

# running
mkdir -p %{buildroot}/%{_localstatedir}/run/%{name}

# man pages
install -d %{buildroot}%{_mandir}/man{5,8}
install -m 0644 %{name}/doc/docbook/*.8 %{buildroot}%{_mandir}/man8
install -m 0644 %{name}/doc/docbook/*.5 %{buildroot}%{_mandir}/man5

========================================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.