[Bug 226223] Merge Review: ORBit2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226223





--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-12-12 09:54:12 EDT ---
For 2.14.16-2:

* Licensing
 
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
  - Please write in the spec file what files are actually
    licensed under GPLv2+.
    As far as I checked the source codes, the codes
    under GPLv2+ are:
------------------------------------------------------
src/idl-compiler/orbit-idl-driver.c
src/idl-compiler/orbit-idl-main.c
src/services/name/name-client.c
test/*.c
test/everything/*.c
test/poa/*.c
------------------------------------------------------
    and these affects files under %_bindir in ORBit2-devel.

    So the license of ORBit2 (main package) should be only
    "LGPLv2+" and only -devel package should have "LGPLv2+
    and GPLv2+" license tag.

! Timestamps
  make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
  is preferrred to keep timestamps on installed files.

* Requires
  - Would you explain why -devel subpackage should have
    "Requires: indent"?

* Documents
  - Please add the following file(s) into main package
------------------------------------------------------
COPYING.LIB
------------------------------------------------------
   - Maybe the following file(s) can be added in -devel subpackage
------------------------------------------------------
ChangeLog
MAINTAINERS
HACKING
------------------------------------------------------

* Shipping static archive
 
https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries
  - Split static archives into -static subpackge so that
    we can keep track of packages really needing the archive.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.