[Bug 476247] Review Request: log4cpp - logging library for c++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476247


Jesse Keating <jkeating at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(jmccann at redhat.co
                   |                            |m)




--- Comment #2 from Jesse Keating <jkeating at redhat.com>  2008-12-12 14:21:55 EDT ---
* Name is OK
* spec matches name
* ERROR: "LGPL" is not a valid license name, please see
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL
* No pre-built binaries found
* Files follow FHS
* Changelog is sane
* Buildroot tag is sane
* Buildroot properly prepped for %install
* No unnecessary requires
* Summary/Description mostly OK, -devel ends in a "." which rpmlint doesn't
like.
* Docs packaged
* No static libs
* No rpath
* Consistent use of macros
* smp flags used for make
* WARNING Patches missing bug or comment
http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
* License review:
  src/AppendersFactory.cpp No license header
  src/BufferingAppender.cpp No license header
  src/DummyThreads.cpp No license header
  src/FactoryParams.cpp No license header
  src/LayoutsFactory.cpp No license header
  src/LevelEvaluator.cpp "
  src/Localtime.cpp "
  src/Localtime.hh "
  src/MSThreads.cpp "
  src/NTEventLogAppender.cpp "
  src/OmniThreads.cpp "
  src/PassThroughLayout.cpp "
  src/PThreads.cpp "
  src/snprintf.c Licensed under "Frontier Artistic License", how does this
interact with the other source?  Where is the text of this license?
  src/TriggeringEventEvaluatorFactory.cpp No license header
  tests/testbench.cpp "
  tests/testCategory.cpp "
  tests/testConfig.cpp "
  tests/testErrorCollision.cpp "
  tests/testFilter.cpp "
  tests/testFixedContextCategory.cpp "
  tests/testmain.cpp "
  tests/testNDC.cpp "
  tests/testNTEventLog.cpp "
  tests/testPattern.cpp "
  tests/testPriority.cpp "
  tests/testProperties.cpp "
  tests/testPropertyConfig.cpp "
* Upstream source matches
* Package builds in mock
* ldconfig called correctly
* defatter set correctly
* Might consider a %doc package given the large number of doc files
* ERROR a .pc file is shipped but pkgconfig is not Required.
* rpmlint output:
  log4cpp.i386: W: file-not-utf8 /usr/share/doc/log4cpp-1.0/ChangeLog
  log4cpp.i386: W: file-not-utf8 /usr/share/doc/log4cpp-1.0/THANKS
  log4cpp.i386: W: invalid-license LGPL
  log4cpp.src: W: invalid-license LGPL
  log4cpp-debuginfo.i386: W: invalid-license LGPL
  log4cpp-devel.i386: W: no-documentation
  log4cpp-devel.i386: W: summary-ended-with-dot Header files, libraries and
development documentation for log4cpp.
  log4cpp-devel.i386: W: invalid-license LGPL

** SUMMARY **
License issues; LGPL is not valid, many packages missing headers, one file
under a license that references a license file that doesn't exist

Summary could nuke '.'

pkgconfig is required since a .pc file is shipped.

comments and/or links missing for the patches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.