[Bug 474012] Review Request: qodem - terminal emulator and communications package.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474012





--- Comment #2 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-12-12 22:25:02 EDT ---
At the first glance, I'd say that the license should be GPLv2+ because all the
source files include either 
   This program is free software; you can redistribute it and/or modify it
   under the terms of the GNU Library General Public License as published
   by the Free Software Foundation; either version 2, or (at your option)
   any later version.
or (note the "later" in the last line )
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
The combination LGPLv2+ + GPLv2+ = GPLv2+

You should also drop the Requires line, rpmbuild will add the dependency
automatically.

The INSTALL file is useless for the users of the packaged qodem so I suggest to
not include it at all. OTOH, you should include the manpage available as
docs/qodem.1.The content of the NEWS file makes reference to a [much] older
version, I would not include it (no problem however if you keep it, but the
elegant procedure would be to remove it now and reinclude it if/when real news
are provided).

For language files there is a special procedure, please read and follow
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files.
Please make sure you do not build your package against the bundled gettext (it
is included below the intl/ directory). You should BuildRequire gettext
instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.