[Bug 472229] Review Request: PyQwt - Python bindings for Qwt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472229


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-12-13 12:21:48 EDT ---
Some notes:

* BuildRequires/Requires 
  - build.log shows
------------------------------------------------------------
    80  Failed to import numarray: PyQwt will be build without support for
numarray.
    81  Failed to find Numeric2: PyQwt will be build without support for
Numeric.
.....
    86   'disable_numarray': False,
    87   'disable_numeric': False,
    88   'disable_numpy': False,
 ------------------------------------------------------------
    These message seems contradictory.
    Perhaps "BuildRequires: python-numarray python-numeric"
    is needed.

  - Also please check if numpy (or python-numarray, python-numeric)
    are also needed for "Requires" (not BuildRequires). 
    For python module related packages, writing a package in 
    "BuildRequires" does not mean that the package is installed
    at runtime.

  - And check if PyQwt-devel does not require "qwt-devel".
    For example, QwtList.sip contains:
-------------------------------------------------------------
    34  %MappedType QList<QwtPickerMachine::Command>
    35  {
    36  %TypeHeaderCode
    37  #include <qlist.h>
    38  #include <qwt_picker_machine.h>
    39  %End
-------------------------------------------------------------

* Timestamps
  - 'INSTALL="install -p"' argument to "make install" does not
    make sense for this package because this makefile is not
    based on autotools but based on python
    (actually when installing files "cp -f" is used)

* Permission of scripts
-------------------------------------------------------------
# non-executable script
chmod 755 %{buildroot}%{python_sitearch}/PyQt4/Qwt5/grace.py
-------------------------------------------------------------
  - If this script is not meant to be called directly by
    users (but is meant to be called internally from programs
    or so), then this script should not have executable
    permission and the shebang should be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.