[Bug 476374] Review Request: OASA - python library for manipulation of chemical formats

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476374


Jesse Keating <jkeating at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(henriquecsj at gmail
                   |                            |.com)




--- Comment #2 from Jesse Keating <jkeating at redhat.com>  2008-12-13 16:20:42 EDT ---
* Python defines correct
* Name not correct.  This is a python module, and should be named python-oasa. 
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29
* Licensing not correct.  Header files have 'or any later version' in them,
therefore license should be GPLV2+
  oasa/elements.py - No license header
  oasa/subsearch_data.py - No license header
  oasa/tests.py - No license header
  oasa/graph/multi_thread.py - No license header
* Summary could drop the "OASA is a"
* URL is OK
* Source matches upstream
* Buildroot fine
* Requires on python is redundant, don't put that in.
* Description is OKish.
* Consistent macro usage
* Correct cleaning at %install
* Good %clean section
* defatters in %files
* %files is a bit broad.  I'd rather see something more like
http://fedoraproject.org/wiki/Packaging/Python#Byte_Compiled_Files
* changelog should have a revision listed.
* rpmlint output:
  oasa.noarch: W: no-documentation
  oasa.noarch: E: description-line-too-long OASA is a free python library for  
manipulating and analyzing chemical structures.
  oasa.noarch: W: incoherent-version-in-changelog 0.12.5 ['0.12.5-1.fc11',
'0.12.5-1']
  oasa.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 3)

** SUMMARY **
Fix license, report unlicensed files to upstream
Fix name
Fix summary
Fix Requires
Potentially fix %files
Fix rpmlint output

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.