[Bug 226463] Merge Review: system-config-netboot
bugzilla at redhat.com
bugzilla at redhat.com
Mon Dec 15 11:14:06 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226463
Fabian Affolter <fabian at bernewireless.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fabian at bernewireless.net
--- Comment #1 from Fabian Affolter <fabian at bernewireless.net> 2008-12-15 06:14:05 EDT ---
Just some comments on this spec file
- Use %defattr(-,root,root,-) instead of %defattr(-,root,root)
- Use parallel make (make %{?_smp_mflags})
- Is there a reason that %makeinstall is used?
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Fedora-package-review
mailing list