[Bug 476599] Review Request: python-transaction - Transaction Management for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476599


Jesse Keating <jkeating at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jkeating at redhat.com
         AssignedTo|nobody at fedoraproject.org    |jkeating at redhat.com
               Flag|                            |fedora-review?




--- Comment #1 from Jesse Keating <jkeating at redhat.com>  2008-12-16 02:44:55 EDT ---
This doesn't build in rawhide currently:

DEBUG: This script requires setuptools version 0.6c7 to run (even to display
DEBUG: help).  I will attempt to download it for you (from
DEBUG: http://pypi.python.org/packages/2.6/s/setuptools/), but
DEBUG: you may need to enable firewall access for this script first.
DEBUG: I will start the download in 15 seconds.
DEBUG: (Note: if this machine does not have network access, please obtain the
file
DEBUG:   
http://pypi.python.org/packages/2.6/s/setuptools/setuptools-0.6c7-py2.6.egg
DEBUG: and place it in this directory before rerunning this script.)


It then tries to download the .egg file which really isn't going to work in the
builders.

Licenses:
tests/test_savepoint.py is under ZPL 2.0 instead of 2.1 like the rest of the
files.  Might be an oversight by the upstream, should contact them, or
otherwise make note in the spec.  I'm not sure what the differences are between
2.0 and 2.1 and what happens when you combine both in a work.

Docs:
the %doc call should include LICENSE.txt since it is shipped with upstream.
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Otherwise, looks good.  Just a few things to fix there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.