[Bug 452413] Review Request: BkChem - Chemical drawing program
bugzilla at redhat.com
bugzilla at redhat.com
Tue Dec 16 20:54:49 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=452413
--- Comment #23 from Terje Røsten <terjeros at phys.ntnu.no> 2008-12-16 15:54:47 EDT ---
Looks good, some minor things:
o rpmlint:
bkchem.src: W: mixed-use-of-spaces-and-tabs (spaces: line 34, tab: line 3)
o use diff -x option or remove setup.py~ to clean up the patch.
o use wget -N to get correct timestamp on tarball.
o maybe change naming: bkchem.patch -> bkchem-remove-oasa.patch ?
I see you are sponsored, congrats!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list