[Bug 472149] Review Request: refmac-dictionary - chemical ligand dictionaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472149


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #8 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-17 00:21:25 EDT ---
The above srpm URL is invalid, but I poked around in the directory and found
it.  Sorry for not getting back to this sooner.

Note that the leading blank line in your %description makes it into the final
output, which probably isn't what you want.  That's really minor, and I can
find nothing worth complaining about.

* source files match upstream.  sha256sum:
  803b7669e09124012db110da71fa8dfdf64ea53c92b4021fbaba3e5638aea00b  
   refmac_dictionary_v5.04.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   refmac-dictionary = 5.04-1.fc11
  =
   (nothing)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* acceptable content.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.