[Bug 468765] Review Request: hydrogen-drumkits - Additional DrumKits for Hydrogen

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468765





--- Comment #14 from Till Maas <opensource at till.name>  2008-12-17 04:25:17 EDT ---
(In reply to comment #12)
> It looks mostly OK. You should move from %{buildroot} to $RPM_BUILD_ROOT as its
> the standard now. Other than that once there's an updated package I'll do a
> full review.

There is nothing wrong with using %{buildroot} in general:
https://fedoraproject.org/wiki/Packaging/Guidelines#macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.