[Bug 473452] Review Request: system-config-services-docs - Documentation for configuring system services

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473452


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #19 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-18 14:29:04 EDT ---
Thanks.  Note that we do generally only use needinfo in package reviews as a
prod in the case one of the parties is not responsive.  In the days before
needinfo was a flag, at least, setting it was the best way of making sure that
it dropped off of the bugzilla front page, thus ensuring that a response would
not be received.

I'll go along with your idea that a simple Requires: rarian-compap should take
care of the scrollkeeper-update bit.  If it isn't installed when the scriptlet
runs then things are OK (the scriptlet will succeed, doing nothing), and if
it's installed later then it will fix up the index.

I note now that 1.1.4 is not available from fedorahosted, and thus I can't
fetch the source.  I'm not going to block the review over that as I'm guessing
it just hasn't shown up there yet.  There was no problem with 1.1.3 and the
sources compared fine.

* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* rpmlint has acceptable complaints.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets are OK.
* acceptable content.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.