[Bug 473972] Review Request: nufw - Authentication Firewall Suite for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473972


Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #12 from Dan Horák <dan at danny.cz>  2008-12-19 04:21:24 EDT ---
formal review is here, see the notes below:

source files match upstream:

OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers are in -devel
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- add "touch -r $f $f.new" between the iconv and mv calls in the charset
conversion to keep the timestamps on modified files
- rpmlint complains about non-standard uid/gid and some non-readable files, but
that's OK due the kind of package

so this package is APPROVED when you add the missing "touch" call before
importing the spec to the CVS

Now I need to see (and review) another your package(s) and/or some pre-reviews
of other packages done by you, before I can sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.