[Bug 225809] Merge Review: gmp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225809





--- Comment #19 from Robert Scheck <redhat-bugzilla at linuxnetz.de>  2008-12-20 09:58:59 EDT ---
For gmp-4.2.4-3, rpmlint doesn't seem to be silent (or is my rpmlint just
broken?):

gmp-devel.i386: E: tag-not-utf8 %changelog
gmp-static.i386: E: tag-not-utf8 %changelog

Ivana, can you explain why a separate %configure is defined, rather using
the default configure from redhat-rpm-config? So if there still is a valid 
reason for this own define, please add an explaining comment to the spec
file, otherwise use %configure (the config.* is no longer copied since F-10
or so, if that was the reason for the own %configure).

Please use "if [ $1 = 0 ]; then" in %preun, currently you're comparing
something quoted.

Please only use "rm -rf $RPM_BUILD_ROOT" in %clean rather the current.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.