[Bug 458440] Review Request: bluemindo - Simple audio player in python/GTK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458440





--- Comment #9 from Fabian Affolter <fabian at bernewireless.net>  2008-12-20 11:50:45 EDT ---
This is the rpmlint output after the rebuild

[fab at laptop024 SRPMS]$ rpmlint bluemindo-0.2.1-2.fc10.src.rpm 
bluemindo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 36, tab: line 4)
bluemindo.src: W: strange-permission 77133a-bluemindo-0.2.1.tar.gz 0755
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

This is easy to fix.

[fab at laptop024 noarch]$ rpmlint bluemindo-0.2.1-2.fc9.noarch.rpm 
bluemindo.noarch: E: script-without-shebang
/usr/share/bluemindo/src/modules/__init__.py
bluemindo.noarch: E: script-without-shebang
/usr/share/bluemindo/src/media/__init__.py
bluemindo.noarch: E: script-without-shebang
/usr/share/bluemindo/src/libs/__init__.py
bluemindo.noarch: E: script-without-shebang
/usr/share/bluemindo/src/gui/__init__.py
bluemindo.noarch: E: script-without-shebang
/usr/share/bluemindo/src/common/__init__.py
bluemindo.noarch: E: script-without-shebang
/usr/share/bluemindo/src/plugins/__init__.py
bluemindo.noarch: E: script-without-shebang
/usr/share/bluemindo/src/handlers/__init__.py
bluemindo.noarch: W: file-not-in-%lang
/usr/share/locale/fr/LC_MESSAGES/bluemindo.mo
bluemindo.noarch: W: file-not-in-%lang
/usr/share/locale/sk/LC_MESSAGES/bluemindo.mo
1 packages and 0 specfiles checked; 7 errors, 2 warnings.

About the shebang stuff, perhaps it is easier to report upstream that they fix
the files.  Or separate those files.

Some comment after a quick look at your new spec file

- %{__install} -d $RPM_BUILD_ROOT%{_bindir} is twice listed
- Where is %{menudir} and %{icondir} defined? Remains from the old spec file?
- 'Keep in mind that usage of %find_lang in packages containing locales is a
MUST.'
  https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
- Check https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files for
the handling of the .desktop file
- You should preserve the timestamps
  https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.