[Bug 475000] Review Request: cmconvert - CacheMate import file converter

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 20 17:23:24 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475000





--- Comment #5 from Fabian Affolter <fabian at bernewireless.net>  2008-12-20 12:23:23 EDT ---
rpmlint output 

[fab at laptop024 SRPMS]$ rpmlint cmconvert-1.9.5-3.fc10.src.rpm 
cmconvert.src:38: E: files-attr-not-set
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

- Is 'mkdir -p -m 0755 %{buildroot}/usr' really needed?
- Use make install DESTDIR=%{buildroot} INSTALL="install -p" to preserve the
timestamps instead of make install DESTDIR=%{buildroot}
- There is no need to pack the file 'INSTALL' because it contains only generic
information which are not useful when installed from RPM

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list