[Bug 477732] Review Request: xfconf - Hierarchical configuration system for Xfce

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477732





--- Comment #2 from Marcela Maslanova <mmaslano at redhat.com>  2008-12-23 07:34:02 EDT ---
OK source files match upstream: 1ca682571554c7704f4c09398b74529d
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field GPLv2 matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is ok:
xfconf-devel.x86_64: W: no-documentation
OK final provides and requires look sane.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK no duplicates in %files.
OK file permissions are appropriate.
OK scriptlets ok.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.

xfconf-perl.x86_64: W: perl-temp-file
/usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi/perllocal.pod
I'm not sure what to do with this file. I have on my computer in perllocal.pod
only log from modules installed in /usr/local. So probably you should remove
this file from your package.

xfconf-perl.x86_64: E: zero-length
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.bs
If it's config file, you should mark it like config.

xfconf-perl.x86_64: W: hidden-file-or-dir
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist
xfconf-perl.x86_64: W: perl-temp-file
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist
You should add into spec the same line as Perl packages have:
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;

xfconf-perl.x86_64: E: non-standard-executable-perm
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.so
0555
The other perl *.so have permission 0755.

xfconf-perl.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl-autogen.h
xfconf-perl.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl.h
In guidelines are no exception. You should create devel package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.