[Bug 477732] Review Request: xfconf - Hierarchical configuration system for Xfce

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477732





--- Comment #5 from Kevin Fenzi <kevin at tummy.com>  2008-12-23 12:03:34 EDT ---
Hey Marcela. Thank you for the quick review!

>I forgot mention that you need review for libxfce4util-4.5.92 first.

libxfce4util is already in fedora, it's just that this package needs the
version from the Xfce 4.6 beta2 release. I am planning on updating it in
rawhide, but wanted to get the new packages reviewed first so I can push all of
4.6b2 out the same day to avoid broken deps. 

>xfconf-perl.x86_64: W: perl-temp-file
>/usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi/perllocal.pod
>I'm not sure what to do with this file. I have on my computer in perllocal.pod
>only log from modules installed in /usr/local. So probably you should remove
>this file from your package.

Yes, I will remove it. 

>xfconf-perl.x86_64: E: zero-length
>/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.bs
>If it's config file, you should mark it like config.

Some more digging around and it seems this is a dynloader bootstrap file. 
It's not needed if it's 0 length. 
http://www.perlmonks.org/?node_id=728926
I will remove it. 

>xfconf-perl.x86_64: W: hidden-file-or-dir
>/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist
>xfconf-perl.x86_64: W: perl-temp-file
>/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/.packlist

>You should add into spec the same line as Perl packages have:
>find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;

Done.

>xfconf-perl.x86_64: E: non-standard-executable-perm
>/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Xfce4/Xfconf/Xfconf.so
>0555
>The other perl *.so have permission 0755.

ok. Changed to 0755. 

>xfconf-perl.x86_64: W: devel-file-in-non-devel-package
>/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl-autogen.h
>xfconf-perl.x86_64: W: devel-file-in-non-devel-package
>/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Xfce4/Xfconf/Install/xfconfperl.h
>In guidelines are no exception. You should create devel package.

>perl has this exception:
>https://fedoraproject.org/wiki/Packaging/Perl#.h_files_in_module_packages

Thanks for spotting that Mamoru. So, I will leave these .h files and not make a
devel subpackage here. 

new spec and src.rpm: 

Spec URL: http://www.scrye.com/~kevin/fedora/xfconf/xfconf.spec
SRPM URL:
http://www.scrye.com/~kevin/fedora/xfconf/xfconf-4.5.92-3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.