[Bug 475032] Review Request: gnaural - A multi-platform programmable binaural-beat generator.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475032





--- Comment #3 from Debarshi Ray <debarshi.ray at gmail.com>  2008-12-24 13:06:24 EDT ---
MUST Items: 

OK - rpmlint is clean

xx - does not follow Naming Guidelines
    + Looking at the upstream release announcement, it looks like 1.0.20080808
      should be the value of the version tag, although they say that the 1.0
      release is "a stable snapshot of the beta Gnaural2". Ubuntu has also
      chosen to include the date in the version tag and not in the release tag.

OK - spec file is named as %{name}.spec

xx - package meets Packaging Guidelines
    + The description is too verbose. Apart from the first sentence, the
      content mainly describes the surrounding research and not Gnaural itself.
    + To preserve timestamps you could consider using:
      make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT
    + According to
      https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
      'install -p' should be used to preserve timestamps.
    + Instead of putting gnaural-icon.png in /usr/share/pixmaps you could
      consider putting it in /usr/share/icons/hicolor/48x48/apps and add
      'Requires: hicolor-icon-theme'. If you do so, then you should use the
      necessary post and postun scriptlets from
     
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
      gnaural-icon.xpm is a better candidate for /usr/share/pixmaps.

OK - Fedora approved license and meets Licensing Guidelines
OK - License field meets actual license
OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible
OK - sources match upstream sources
OK - package builds successfully
OK - ExcludeArch not needed

xx - redundant and extra build dependencies listed
    + pkgconfig is brought in by all the -devel packages providing *.pc files

OK - no locales
OK - no shared libraries
OK - package is not relocatable
OK - file and directory ownership
OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc is not needed
OK - contents of %doc does not affect the runtime
OK - no header files
OK - no static libraries
OK - no pkgconfig files
OK - no library files
OK - -devel is not needed
OK - no libtool archives

xx - %{name}.desktop file is not properly installed
    + If the package installs a .desktop file, then desktop-file-install must
      be run. In this case mv can not be used. See
     
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage
    + According to
     
https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files
it is better to use only 'gnaural-icon' as the value for the Icon tag in
      order to support theming.

OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8

SHOULD Items:

OK - upstream provides license text
xx - no translations for description and summary
OK - package builds in mock successfully
OK - package builds on all supported architectures
OK - package functions as expected
OK - scriptlets are sane
OK - subpackages are not needed
OK - no pkgconfig files
OK - no file dependencies

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.