[Bug 476360] Review Request: rubygem-tlsmail - This library enables pop or smtp via ssl/tls

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 26 14:55:12 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476360





--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-12-26 09:55:11 EDT ---
For 0.0.1-1:

* Documents
  - Would you check if Rakefile or Manifest.txt really needed?
  - README.txt should be marked as %doc.

* Possibly duplicate/conflicting files with system ones
  - This rpm contains net/pop.rb, net/smtp.rb. These are
    already included in ruby-libs rpm (however the files
    in ruby-libs seems older than those in this rpm).
    Can these files safely installed in parallel?

* CRLF line terminators
  - Some ruby scripts in this rpm have CRLF line terminators
    (although my rpmlint could not detect them...)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list