[Bug 471145] Review Request: procinfo-ng - System monitoring application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471145





--- Comment #5 from Fabian Affolter <fabian at bernewireless.net>  2008-12-27 06:32:08 EDT ---
Michael, thanks for your inputs.

(In reply to comment #3)
> > g++ -O0 -g3 --pipe -Wall -lncurses procinfo.cpp -o procinfo
> 
> It ignores our global %{optflags}, also influenced by switching on
> --enable-maintainer-mode. You want to make it accept $CFLAGS (as it doesn't use
> $CXXFLAGS for C++) and make sure that $LDFLAGS does not include -s (to avoid
> stripping the binaries as that would make the debuginfo pkg useless).

fixed

> > /usr/bin/procinfo-ng
> 
> It builds just this executable (renamed from "procinfo") and therefore is not
> suitable as a direct replacement of the procinfo package, which includes
> "lsdev" and "socklist".
> 
> It is NOT options-compatible with the "procinfo" pkg either.
> 
> It conflicts with package "procinfo" in the manual page file, which you forgot
> to rename to procinfo-ng.8

I renamed the man page now.  It's the same man page as in procinfo as far as I
can see.   lsdev and socklist are missing in procinfo-ng.

(In reply to comment #4)
> > Summary:        System monitoring application
> 
> It's text-based (ncurses), which is special enough to mention that. Else a
> summary like this is misleading, since most users will expect a modern desktop
> GUI application that adds a menu entry, too.

Changed

Here are the new files

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/procinfo-ng.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/procinfo-ng-2.0.217-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.