[Bug 471754] Review Request: virtaal - Localization and translation editor

Sat Dec 27 21:19:10 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=471754

--- Comment #6 from Brennan Ashton <bashton at brennanashton.com>  2008-12-27 16:19:08 EDT ---
[x]source files match upstream:
b7942cb1b57897119062f6ff7a30c970b754e7d2728297a32228b02272785695 
virtaal-0.2.tar.bz2
[x]package meets naming and versioning guidelines.
[FAIL]specfile is properly named, is cleanly written and uses macros
consistently.
The spec file should not have the version or at least not the revision number
as part of its name, it should be virtaal.spec

[x]dist tag is present.
[x]build root is correct.
 (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

[x]license field matches the actual license.
[x]license is open source-compatible.
GPLv2+
[x]license text included in package.
[x]latest version is being packaged.
[FAIL]BuildRequires are proper.

You should not have desktop-file-utils see:
http://fedoraproject.org/wiki/NewMIMESystem

[x]compiler flags are appropriate.
[x]%clean is present.
[x]package builds in mock.
package installs properly.
[FAIL]rpmlint is silent.

rpmlint virtaal-0.2-2.spec ../SRPMS/virtaal-0.2-2.fc10.src.rpm
../RPMS/noarch/virtaal-0.2-2.fc10.noarch.rpm 
virtaal.src: E: invalid-spec-name

Rename Spec file

virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/recent.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/about.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/label_expander.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/markup.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/document.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/formats.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/simplegeneric.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/tips.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/undo_buffer.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_editor.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/store_grid.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/search_mode.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_renderer.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/bijection.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/__init__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/partial.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/openmailto.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/autocorrector.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/unit_layout.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/terminology.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/memoize.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/main_window.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/sorted_set.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/entry_dialog.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/pan_app.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/mode_selector.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/widgets/util.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/autocompletor.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/store_model.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/modes.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/support/set_enumerator.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/__version__.py 0644
virtaal.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/virtaal/rendering.py 0644
2 packages and 1 specfiles checked; 36 errors, 0 warnings.

[x]final provides and requires are sane:
  (paste in the rpm -qp --provides and --requires output)

[x]owns the directories it creates.
[x]doesn't own any directories it shouldn't.
[x]no duplicates in %files.
[x]file permissions are appropriate.
[x]no scriptlets present.
[x]code, not content.
[x]documentation is small, so no -docs subpackage is necessary.
[x]%docs are not necessary for the proper functioning of the package.
[x]no libtool .la droppings.
[?]desktop files valid and installed properly.
The version in the desktop file is 1.0 but 0.2 for the package is that correct?

There are a few things that need to be fixed before I will sign this package
off.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.