[Bug 477953] Review Request: podcatcher - Armangil's podcast client for the command line

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477953





--- Comment #2 from Christof Damian <christof at damian.net>  2008-12-27 16:58:40 EDT ---
(In reply to comment #1)
> Just some comments on your spec file
> 
> - 'Source0:' should point to the upstream tarball if possible. 

fixed, though the URL has to be looked up again on every release because it
contains some release id

> - Please preserve the time stamp in the %install section

fixed

> - Shouldn't '%doc demo' be '%doc demo/' ?

I changed it. I didn't realize that it makes a difference, but it is easier
readable. 

> - Replace '/usr/bin/' with a macro
>   https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros

OK.

> rpmlint is not quite...
> 
> [fab at laptop024 SRPMS]$ rpmlint podcatcher-3.1.4-1.fc10.src.rpm 
> podcatcher.src: E: no-cleaning-of-buildroot %install
> podcatcher.src: W: more-than-one-%changelog-section
> podcatcher.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 16)
> 1 packages and 0 specfiles checked; 1 errors, 2 warnings.

those are now fixed too.

I have uploaded the new files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.