[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476536


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-12-27 17:27:46 EDT ---
Just some comments on your spec file

- The echo call in the %prep section is a bit unusual
- The license is not GPLv2, it's GPLv2+ according to the header in the source
file
- One line per BR would be nice
- There is no need for '\' in the description
- From my point of view, there is no need for 'chmod 755
%{buildroot}%{_bindir}/%{name}'

The guidelines says that the BuildRequires for python packages should be
'BuildRequires: python' and the egg stuff 'BuildRequires:
python-setuptools-devel'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.