[Bug 455164] Review-Request: NaturalDocs - Documentation generator for multiple programming languages

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 27 22:46:35 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455164


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2008-12-27 17:46:34 EDT ---
> Issues: 
> 
> 1. It looks pretty clear that the package is GPLv2+, but some of the files just
> say 
> "the GPL". You might ping upstream about that and suggest they mention that
> it's v2 or
> later. 
>
> 2. Might use 'install -p' to preserve the timestamp on the script. 
> 
> 3. SourceUrl is not right... looks like they use naturaldocs instead of
> NaturalDocs
> in there. 
> Ie: 
> 
> http://downloads.sourceforge.net/naturaldocs/%{name}-%{version}.zip
> 
> None of those are blockers, so this package is APPROVED, provided you 
> fix those up on import.

All three are reasonable and I will surely address them. Thanks for the review!

New Package CVS Request
=======================
Package Name: NaturalDocs
Short Description: Documentation generator for multiple programming languages
Owners: lkundrak
Branches: F-9 F-10 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list