[Bug 478368] Review Request: linsmith - a Smith Charting program
bugzilla at redhat.com
bugzilla at redhat.com
Mon Dec 29 05:41:01 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478368
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review?
--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2008-12-29 00:41:00 EDT ---
33256af1c310309da6f03f2a2fe8a869 linsmith-0.99.11.tar.gz
http://koji.fedoraproject.org/koji/taskinfo?taskID=1024295
1) 'desktop-file-install --vendor="fedora" \' is obsolete for new packages.
Check https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor
2) install command should be
%{__make} install DESTDIR=%{buildroot} INSTALL="install -p"
3)gtk-update-icon-cache scriptlet not needed as no icons installed in
%{_datadir}/icons/hicolor
4) Also, I see its not needed to have update-desktop-database scriptlet. from
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database ==>
Use this when a desktop entry has a 'MimeType key.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list