[Bug 477190] Review Request: cas - core analysis system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477190





--- Comment #4 from Adam Stokes <astokes at redhat.com>  2008-12-29 06:34:27 EDT ---
(In reply to comment #3)
> Looking at the code, it looks like it is GPLv3+.

Thanks for the catch, this makes sense as I am not committed to v3 only

> 
> Why are the man pages separate from the upstream source? Seems like they'd be a
> logical fit to go inside the tarball, or at the very least, uploaded to the
> fedorahosted site. If you opt for the latter route, please provide full
> upstream URLs.

Fixed
> 
> Do you still need Source1? It doesn't seem to be used anymore.

Fixed
> 
> You also don't need the Requires: python >= 2.4
> 
> Fedora's RPM will detect the python bits in the package and add a proper
> versioned Requires on python(abi). For example, in rawhide, we get:
> 
> [spot at velociraptor ~]$ rpm -qp
> /home/spot/rpmbuild/RPMS/noarch/cas-0.13-113.fc11.noarch.rpm --requires
> /usr/bin/python  
> config(cas) = 0.13-113.fc11
> crash  
> python >= 2.4
> python(abi) = 2.6
> rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(PartialHardlinkSets) <= 4.0.4-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> 
> Thus, your manual python Requires is unnecessary.
Fixed

> 
> Also, the last sentence of the description doesn't make much sense. Can you fix
> that up a bit? :)

Hopefully I cleared up the description, my writing skills are subpar :(

Thanks

http://astokes.fedorapeople.org/cas-0.13-114.src.rpm
http://astokes.fedorapeople.org/cas.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.