[Bug 478399] Review Request: ircp-tray - Infrared file transfer applet for GNOME panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478399





--- Comment #2 from Dan Horák <dan at danny.cz>  2008-12-29 09:01:52 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     ed6b34290c06150f168a31f5e137dbfbf7fcfa94  ircp-tray-0.7.3.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
BAD BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
BAD no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
BAD GUI app with desktop file.

- no need to have pkgconfig as BR: , it is resolved from all used -devel BRs,
gtk2-devel is a dependency of libnotify-devel, so the BRs should be only
"intltool gettext libnotify-devel openobex-devel"
- what is the reason for using a file as Requires?
(https://fedoraproject.org/wiki/Packaging/Guidelines#File_Dependencies)
- the desktop file is listed twice in %files
- upstream desktop file installed, but not validated
(https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.