[Bug 457210] Review Request: dpkg - Package maintenance system for Debian Linux
bugzilla at redhat.com
bugzilla at redhat.com
Tue Dec 30 08:02:47 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457210
--- Comment #26 from Ralf Corsepius <rc040203 at freenet.de> 2008-12-30 03:02:42 EDT ---
There are still several issues:
SHOULD:
- In dkg's %files, you are inconsistently using %name and dpkg.
Please only use one of them. I recommend to use dpkg, only.
- You are still using %packagename. Please stop it.
- The latin1->utf8 transformation of the man-pages should be performed
in %build.
MUSTFIX:
- There is a circular dependency between the dpkg and dpkg-dev, introduced by
the perl modules (dpkg can not be installed without dpkg-dev).
I see 3 alternatives to work around this issue:
a) package the perl modules as separate package (e.g. perl-Dpkg)
b) move all perl modules into dpkg
c) try to sort out the details of the perl module deps.
I for one would choose alternative a).
b) is almost equivalent to a), while c) is likely difficult to implement,
if possible at all.
- Several directories are unowned, e.g.
/etc/dpkg/origins
/usr/lib/perl5/vendor_perl/5.10.0/Dpkg/Source
/usr/lib/perl5/vendor_perl/5.10.0/Dpkg/Shlibs
- Files below %{_mandir} automatically receive %doc
=> the %doc inside of your
%lang(xx) %doc %{_mandir} ...
lists are superfluous. Please remove them.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list