[Bug 478432] Review Request: dwscan - Displays access point information

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 30 10:13:00 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478432





--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2008-12-30 05:12:59 EDT ---
Thanks Ralf for your inputs.

(In reply to comment #1)
> - Your patch is superfluous.
>   Overriding at make-time:
>   make install bindir=%{_bindir}
>   has the same effect without hacking the code.

It's much smarter.  Changed

> - The Makefile doesn't honor INSTALL 
>   => make INSTALL="install -p"
>   is non-functional

fixed

> Furthermore:
> - I am having strong doubts if installing this tool to %{_bindir} is a good
> idea.

What location do you have in mind?

Here are the updated files.

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/dwscan.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/dwscan-0.2-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list