[Bug 478290] Review Request: screenie - A small and lightweight screen wrapper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478290


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review+




--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-12-30 17:54:29 EDT ---
You must add awk and screen as Requires, rpmbuild does not pick them and
without them screenie bails out. sort is also a required program, but it is
provided by coreutils and I guess it's safe enough to assume that coreutils is
installed on any system where screenie would be used


Everything else seems fine, package is too simple (it's just a shell script) to
include a full review.
- RPM name is OK
- rpmlint is empty
- license is OK (GPLv2+)
- source screenie_1.30.0.orig.tar.gz is the same as upstream
1f04b055c30f5f8e4f35160bf50cfa060472a61a screenie_1.30.0.orig.tar.gz
- builds fine in mock (devel/x86_64)) and being a simple shell script it's safe
to assume it will work on any arch
- file list is OK, even timestamps are preserved
- works OK (when awk and screen are installed!)

======
Package APPROVED but please add manual requires for awk and screen
======

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.