[Bug 431156] Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-openid - Ruby library for verifying and serving OpenID identities


https://bugzilla.redhat.com/show_bug.cgi?id=431156





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-01 06:24 EST -------
For 2.0.3-1:

* Unneeded CFLAGS
  -  export CFLAGS=... can be (and should be) removed because
     this is noarch package.

! Check
 - Please add:
------------------------------------------------------------
%check
export RUBYLIB=$RPM_BUILD_ROOT%{ruby_sitelib}

# some tests need net connection
ruby setup.rb test || :
------------------------------------------------------------
    Some tests need net connection and they fail, however IMO
    it is better not to skip all tests because of net connection
    missing.

? Documents split
-------------------------------------------------------------
[tasaka1 at localhost ruby-openid-2.0.3]$ du -sh lib/
380K    lib/
[tasaka1 at localhost ruby-openid-2.0.3]$ du -sh doc/
3.7M    doc/
--------------------------------------------------------------
  - The size of openid module itself is only 380K, while the size
    of documents is about 10 times of that.
    You may want to split documents files to a subpackage rpm?

? Examples
  - Would you consider to add files under examples/ to
    %doc? I don't know well about Ruby on Rails, however it seems
    that there are some useful examples for RoR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.