[Bug 187243] Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)


https://bugzilla.redhat.com/show_bug.cgi?id=187243





------- Additional Comments From joost at cnoc.nl  2008-02-01 19:05 EST -------
(In reply to comment #38)
> So this is back in the pool.  Perhaps I'll find the time to look at it if nobody
> beats me to it.  If the package in comment 34 is the one you'd like reviewed,
> please say so or go ahead and drop another package.

Great that you want to help me to improve this package.

> However, some things I didn't see mentioned before.  One warning from
> desktop-file-install during the package build:

Fixed

>   lazarus.src: W: invalid-license GPL, MPL
>   lazarus.src: W: invalid-license modified LGPL
> Please use proper License tags according to
> http://fedoraproject.org/wiki/Licensing and
> http://fedoraproject.org/wiki/Packaging/LicensingGuidelines.  If the "modified
> LGPL" in use doesn't fit any existing tags and something like "LGPLv2+ with
> exceptions" isn't close enough then you will need to have the licensing experts
> assign a new tag for you.

I've asked on the fedora-legal-list and they said I should use the "LGPL+ with
exceptions" tag with a note that it was in fact the GNU classpath-exception
 
>   lazarus.x86_64: E: non-executable-script 
>    /usr/lib64/lazarus/components/lazreport/doc/cvs2cl.pl 0644
>   lazarus.x86_64: E: non-executable-script 
>    /usr/lib64/lazarus/examples/trayicon/createbundle.sh 0644
>   lazarus.x86_64: E: non-executable-script 
>    /usr/lib64/lazarus/components/lazreport/tools/localize.sh 0644
> Are you sure these shouldn't be executable?  What will call them?

First script is obsolete, but I added the execute-flag anyway. Second is a
script used on OS/X only, so that shoudn't be executable. And the last script
should indeed have the executable-flag set. Fixed.


>   lazarus.x86_64: E: non-executable-script 
>    /usr/lib64/lazarus/tools/install/cross_unix/debian_crosswin32/postrm 0644
> I thought that according to comments above that this would be going away.

I didn't saw these files. Removed them.
 
>   lazarus.x86_64: W: ldd-failed /usr/lib64/lazarus/tools/svn2revisioninc
> I think this was covered in a discussion above about fpc output always being
> static, and should be OK.

I've made a new package with these changes: (build with f7, I have no other
system available here atm):  http://www.cnoc.nl/fpc/lazarus-0.9.24-2.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.