[Bug 431277] Review Request: ocfs2-tools - programs for managing Ocfs2 file systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems


https://bugzilla.redhat.com/show_bug.cgi?id=431277


sundaram at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sundaram at redhat.com




------- Additional Comments From sundaram at redhat.com  2008-02-01 21:26 EST -------
I can't sponsor you but a quick review nevertheless:
 
You can drop the Exclusiveos tag since this spec file is just for Fedora. 

Using a disttag is recommended

http://fedoraproject.org/wiki/Packaging/DistTag

You must drop all BuildRequires that are part of the default build root such as
bash. Refer

http://fedoraproject.org/wiki/Packaging/Guidelines#head-4cadce5e79d38a63cad3941de1dadc9d25d67d30-2

Why is there a Provides: ocfs2-tools-static = %{version}-%{release}? Can't you
dynamically link libraries? If not, you should provide a justification for
statically linking any libraries. 

Refer 

http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

The buildroot is non-standard. Use one of the alternatives specified in

http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473

/usr/share can be replaced by %{_datadir} and use %{_initrddir} instead of
/etc/init.d and so on to avoid hard-coding patches wherever applicable. 

Refer

http://fedoraproject.org/wiki/Packaging/RPMMacros

Python 2.5 path should not be hardcoded. You should use {python_sitelib} and
other guidelines outlined in

http://fedoraproject.org/wiki/Packaging/Python

Requires for ocfs2console and similar constructs should probably be {version} -
{release} instead of just {version}. 

Use make %{?_smp_mflags} if possible. 

You might want to branch to EPEL 5 when you get approved. 

http://fedoraproject.org/wiki/EPEL


  

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.