[Bug 431044] Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ccom - Perl module for context-sensitive phonetic string replacement


https://bugzilla.redhat.com/show_bug.cgi?id=431044


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-02-02 12:28 EST -------
Builds OK and rpmlint is silent.

The naming is a bit tough; this isn't a CPAN module and the tarball name
(phonet.tgz) doesn't match the module name, but it does unpack into a directory
which matches the module name.  Odd.  CPAN has no hits for either "phonet" or
"ccom".  I'd tend to agree with you that perl-ccom is a better name than
perl-phonet; this wouldn't be the first time upstream has chosen a tarball name
that has nothing to do with the actual software.

There's a language oddity in the description; I assume it comes from a
mistranslation.  The words "tail" and "tale" do not have the same spelling, but
they have the same pronunciation.  I think everything is correct if you just
s/spelling/pronunciation/.

* source files match upstream:
   05f04c7f0d4a4294d3af3df8ee07fdfe397ae1b30ac36d01ec1a381399e0830b
   phonet.tgz
* package meets naming and versioning guidelines as far as I can tell.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
? description needs a 
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   ccom.so()(64bit)
   perl(ccom) = 1.4
   perl-ccom = 1.4.1-1.fc9
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(AutoLoader)
   perl(Carp)
   perl(DynaLoader)
   perl(Exporter)
   perl(strict)
   perl(vars)

* %check is present and passes (not much of a test suite, but it runs):
   1..1
   ok 1

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED, just fix up the description.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.