[Bug 429221] Review Request: dzcomm - Dzcomm a RS-232 API/lib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dzcomm - Dzcomm a RS-232 API/lib


https://bugzilla.redhat.com/show_bug.cgi?id=429221





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-03 06:11 EST -------
First where is your new spec/srpm? (please change the release number
every time you modify your spec file to avoid confusion)

(In reply to comment #4)
> (In reply to comment #2)
> > * Please make it sure that fedora specific compilation flags are
> >   honored correctly ("Compiler flags" of
> >   http://fedoraproject.org/wiki/Packaging/Guidelines )
> > * Compilation flag "-O3" is not allowed for Fedora because this
> >   makes debugging difficult.
> > * Also "-fomit-frame-pointer" is forbidden
> > * And please consider to remove "-ffast-math" as this relaxes
> >   calculation precision and may cause debugging difficult.
> "make %{?_smp_mflags}" changed to "make %{optflags} %{?_smp_mflags}"
I guess "make %optflags %{?_smp_mflags}" won't work.

> Does this cover the -O3 flag? Was that being used as the default? (I am not sure
> how -O3 was making it in there).
No. Fedora specific compilation flags can be checked by
"rpm --eval %optflags". On rawhide i386 system, this returns:
----------------------------------------------------------------------------
[root at localhost ~]# rpm --eval %optflags
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables
----------------------------------------------------------------------------

> Removal of -ffast-math? should the %{optflags} take care of this also?
> Just looked at the configure script... Should I just remove the CFLAGS= line
> then gcc would default to whatever the environment is set to (wich should be
> %{optflags})? If so I can patch the configure file.
It seems that some patch is needed against configure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.