[Bug 226428] Merge Review: speex

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: speex


https://bugzilla.redhat.com/show_bug.cgi?id=226428


matthias at rpmforge.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(matthias at rpmforge.|
                   |net)                        |




------- Additional Comments From matthias at rpmforge.net  2008-02-03 08:19 EST -------
Continuing review :
 * There is still a mess mix of spaces and tabs in the spec file (minor)
 * Passing --with-ogg-libraries=%{_libdir} is not needed
 * The "chmod a-x README" makes more sense in %prep than in %install
 * Why "--enable-static" as the static libs are excluded in %files?
 * Why are libspeexdsp.so and libspeexdsp.a in the main package? (major!)
 * The "rm -f $RPM_BUILD_ROOT%{_docdir}/speex-*/manual.pdf" line is wrong,
   should be "rm -f $RPM_BUILD_ROOT%{_docdir}/speex/manual.pdf"
 * The "%{_defaultdocdir}/speex/manual.pdf" line in %files should be removed
   to avoid including the PDF manual twice (after fixing the above rm).

And what about my suggestion of splitting out the two binaries into their own
sub-package, like many other codec library packages do?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.