[Bug 430339] Review Request: libgringotts - The libgringotts provides a backend for managing the data files on the disk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgringotts - The libgringotts provides a backend for managing the data files on the disk


https://bugzilla.redhat.com/show_bug.cgi?id=430339


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-02-03 21:35 EST -------
Builds OK; rpmlint says:
  libgringotts.x86_64: E: summary-too-long The libgringotts provides a backend
    for managing encrypted data files on the disk
which indeed is too long.  How about changing "The libgringotts provides a" to
just "A".  There's no reason to mention the name of the package in the summary,
and this change would shorten it and make the English sound a bit better.  You
might as well change "the disk" to "disk" since that's how we tend to say it.

In addition, as Bill mentioned in comment 3, you might as well use the nice
description provided in the README file:

----
libGringotts is a small, easy-to-use, thread-safe C library originally
developed for Gringotts; its purpose is to encapsulate data (generic: ASCII,
but also binary data) in an encrypted and compressed structure, to be written
in a file or used elseway. It makes use of strong encryption algorithms, to
ensure the data are as safe as possible, and allow the user to have the complete
control over all the algorithms used in the process.
----

which is much more useful than what you have currently in %description.

I note version 1.2.9 was released around the time you submitted this; any reason
for not submitting that version?

The -devel package installs a .pc file but does not depend on pkgconfig.

* source files match upstream:
   a75e6f757b975d3da662fe7ea2d985f358f31ad2dede1a222bb4aa403d0dbfd1  
   libgringotts-1.2.1.tar.bz2
* package meets naming and versioning guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
X summary needs a tweak
X you should probably the nuice description upstream provides.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
X latest version is not being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
X rpmlint has a valid complaint.
X final provides and requires:
  libgringotts-1.2.1-2.fc9.x86_64.rpm
   libgringotts.so.2()(64bit)
   libgringotts = 1.2.1-2.fc9
  =
   /sbin/ldconfig
   libbz2.so.1()(64bit)
   libgringotts.so.2()(64bit)
   libmcrypt.so.4()(64bit)
   libmhash.so.2()(64bit)
   libz.so.1()(64bit)

  libgringotts-devel-1.2.1-2.fc9.x86_64.rpm
   libgringotts-devel = 1.2.1-2.fc9
  =
   libgringotts = 1.2.1-2.fc9
   libgringotts.so.2()(64bit)
   (no dependency on pkgconfig)

* %check is not present; no test suite upstream.
* shared libraries installed; ldconfig called properly.
* unversioned .so files are in the -devel package.
X directory ownership issue in -devel package due to the lack of a pkgconfig 
   dependency.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
X pkgconfig files present and in the -devel package, but no pkgconfig 
   dependnecy.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.