[Bug 431368] Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print


https://bugzilla.redhat.com/show_bug.cgi?id=431368


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-02-04 01:55 EST -------
Review:
+ package builds in mock.
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
378f8830bc66804d5fe2e7338598e654  Inconsolata.sfd
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
  strings  Inconsolata.sfd | grep OFL
Copyright: Created by Raph Levien using his own tools and FontForge. Copyright
2006 Raph Levien. Released under the SIL Open Font License,
http://scripts.sil.org/OFL.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ followed fonts packaging guidelines.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.