[Bug 428973] Review Request: vodovod - a pipe connecting game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vodovod - a pipe connecting game


https://bugzilla.redhat.com/show_bug.cgi?id=428973





------- Additional Comments From kvolny at redhat.com  2008-02-04 08:28 EST -------
(In reply to comment #2)
> [XX] spec file name matches base package %{name}, in the format %{name}.spec
>  - vodovod.spec.0.10 was odd, not sure if that was just for your hosting or
>    what

this is only a primitive VCS to be sure that the linked file does not change 
and so two people are not referring different state of things - as you noted 
in comment #3, I do not use the suffix for packaging


(In reply to comment #6)
> line 4, summary: probably shouldn't contain
> the package name.

ops, I've copied this and forgot about the rule

> also, should the comment in the .desktop file have a period at the end?

probably not, removing

(In reply to comment #7)
> * This package does not build on dist-f9.
> http://koji.fedoraproject.org/koji/taskinfo?taskID=392156
>   A proposed patch is attached.

thanks, included

> * On build fedora specific compilation flags are not correctly
>   honored ("Compiler flags" of
>   http://fedoraproject.org/wiki/Packaging/Guidelines )
>   Using
> --------------------------------------------------------------------
> make %{?_smp_mflags} \
>         CC="%{__cxx} %{optflags}"
> --------------------------------------------------------------------
>   is good for this package.

well, the guidelines could be more verbose about this ... thanks, added

> - Desktop icon must be updated ("GTK+ icon cache" of
>   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )

thanks, included - once more, it could be mentioned within the guidelines (I'm 
KDE user, so ...)

new version:
http://www.hajnet.cz/soubory/vodovod/vodovod.spec.1.10-2
http://www.hajnet.cz/soubory/vodovod/vodovod-1.10-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.