[Bug 225240] Merge Review: alchemist

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: alchemist


https://bugzilla.redhat.com/show_bug.cgi?id=225240


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

limb at jcomserv.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From limb at jcomserv.net  2008-02-04 14:11 EST -------
rpmlint on SRPM:

alchemist.src: E: non-utf8-spec-file
/tmp/alchemist-1.0.37-2.fc8.src.rpm.5684/alchemist.spec
The character encoding of the spec file is not UTF-8.  Convert it for
example using iconv(1).

alchemist.src:10: W: prereq-use /sbin/ldconfig
The use of PreReq is deprecated. In the majority of cases, a plain Requires
is enough and the right thing to do. Sometimes Requires(pre), Requires(post),
Requires(preun) and/or Requires(postun) can also be used instead of PreReq.

alchemist.src:13: W: buildprereq-use libxml2 >= 2.3.8, libxslt >= 0.9.0,
libxslt-devel >= 0.9.0
The use of BuildPreReq is deprecated, build dependencies are always required
before a package can be built.  Use plain BuildRequires instead.

alchemist.src:14: W: buildprereq-use doxygen >= 1.2.7, python-devel, zlib-devel
The use of BuildPreReq is deprecated, build dependencies are always required
before a package can be built.  Use plain BuildRequires instead.

alchemist.src: W: summary-ended-with-dot A multi-sourced configuration back-end.
Summary ends with a dot.

alchemist.src: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.

alchemist.src: W: no-url-tag
The URL tag is missing.

All need fixing.

rpmlint on RPMS:

alchemist-devel.i386: W: dangling-relative-symlink
/usr/lib/alchemist/blackbox/libforgeblackbox.so libforgeblackbox.so.0.0.0
The relative symbolic link points nowhere.

Should be OK.


In addition, the Source0 tag should include a URL, which should match what I'd
find on the site in the URL.

Static libs need to be in a -static package or dropped entirely.  .la should be
removed unless critically needed.

Otherwise, looks good, no other blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.