[Bug 225250] Merge Review: antlr

Tue Feb 5 16:29:32 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: antlr

https://bugzilla.redhat.com/show_bug.cgi?id=225250

bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

limb at jcomserv.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From limb at jcomserv.net  2008-02-05 11:29 EST -------
rpmlint on SRPM:

antlr.src:375: W: macro-in-%changelog _bindir
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

Fix.

antlr.src: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 76)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

Fix.

antlr.src: W: non-standard-group Development/Code Generators
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

I'd use Development/Tools.

rpmlint on rpms:

antlr.i386: W: devel-file-in-non-devel-package /usr/include/antlr/ANTLRUtil.hpp
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

etc. . .. 

Ok, due to the nature of the package.

antlr.i386: W: incoherent-version-in-changelog 2.7.7-1jpp.6 0:2.7.7-1jpp.6.fc8
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

Fix.

antlr-javadoc.i386: W: dangerous-command-in-%post rm
antlr-javadoc.i386: W: dangerous-command-in-%postun rm

It looks like these are necessary, so OK.

Need to include something about how the RHCLEAN tarball can be produced from the
upstream tarball.

Mock build error:

>> /usr/bin/make -C lib/cpp/antlr all
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
make[3]: Entering directory `/builddir/build/BUILD/antlr-2.7.7/lib/cpp/antlr'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/builddir/build/BUILD/antlr-2.7.7/lib/cpp/antlr'
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>> /usr/bin/make -C lib/cpp/src all
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
make[3]: Entering directory `/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src'
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/ANTLRUtil.cpp
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/ASTFactory.cpp
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/ASTNULLType.cpp
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/ASTRefCount.cpp
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/BaseAST.cpp
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/BitSet.cpp
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/CharBuffer.cpp
*** compiling
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/CharScanner.cpp
In file included from
/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/../../../lib/cpp/src/CharScanner.cpp:10:
/builddir/build/BUILD/antlr-2.7.7/scripts/../lib/cpp/antlr/CharScanner.hpp: In
member function 'bool antlr::CharScannerLiteralsLess::operator
/builddir/build/BUILD/antlr-2.7.7/scripts/../lib/cpp/antlr/CharScanner.hpp:565:
error: 'strcasecmp' was not declared in this scope

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
                      >> E R R O R <<
============================================================

g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasy

============================================================
Got an error while trying to execute  command  above.  Error
messages (if any) must have shown before. The exit code was:
exit(1)
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
make[3]: *** [/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src/CharScanner.o] Error 1
make[3]: Leaving directory `/builddir/build/BUILD/antlr-2.7.7/lib/cpp/src'
make[2]: *** [all] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/antlr-2.7.7/lib/cpp'
make[1]: *** [all] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/antlr-2.7.7/lib'
make: *** [all] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.85628 (%build)

Otherwise, looks good, no other blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.