[Bug 428798] Review Request: OmegaT - Computer Aid Translation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OmegaT - Computer Aid Translation tool


https://bugzilla.redhat.com/show_bug.cgi?id=428798


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-06 03:51 EST -------
Well, for general packaging guidelines you can refer to:
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

- First remove non-fedora-related parts/macros and replace
  them properly.
  * %mkrel is not defined
  * MandrivaLinux is not related to us.
  * Please remove the redundant if "%{_vendor}" != "redhat" &&...
    check
  * %{clean_desktop_database} is perhaps not defined.
- You don't have to define %version, %release redundantly.
- Source must be given with full URL.
  http://fedoraproject.org/wiki/Packaging/SourceURL
- "GPL" license tag is invalid for Fedora.
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
- When using "cp" or "install" commands, please add "-p" option
  to keep timestamps on installed files
- When installing desktop files, "desktop-file-install" command
  must be properly used.
- For desktop files, the category "Application" is deprecated and
  should be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.