[Bug 431161] Review Request: mathmap - A gimp plugin and commandline tool

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 6 13:17:01 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mathmap - A gimp plugin and commandline tool


https://bugzilla.redhat.com/show_bug.cgi?id=431161


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-06 08:17 EST -------
First of all, rebuild doesn't succeed.
http://koji.fedoraproject.org/koji/taskinfo?taskID=398683
You can check this by koji scratch build.

>From just glancing at your spec file:
- Source must be given with full URL
- Fedora specific compilation flags don't seem to be honored
  correctly.
- Would you try to use relative symlink instead of absolute one?
- When using "install" or "cp" commands, add "-p" option to keep
  timestamps on installed files.
- It seems "Requires: gimp" is needed because 
  `gimptool --gimpdatadir` is owned by gimp but not by gimp-libs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list