[Bug 427061] Review Request: redmode - Switch to and from night red mode

bugzilla at redhat.com bugzilla at redhat.com
Fri Feb 8 09:39:51 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: redmode - Switch to and from night red mode


https://bugzilla.redhat.com/show_bug.cgi?id=427061


lkundrak at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |fedora-review?




------- Additional Comments From lkundrak at redhat.com  2008-02-08 04:39 EST -------
Oops, pardon -- not yet ready for approval.

1.) rpmlint

redmode.x86_64: W: non-conffile-in-etc /etc/redmode.conf
Please add %config(noreplace) to the corresponding line in %files.
Note, if it's not meant to be modifiable by user, it would be better in %{_datadir}

2.) please add

BuildArch: noarch

so that -debuginfo doesn't get generated, etc. I believe the script is noarch,
isn't it?



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list