[Bug 431955] Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-URL-Mapper - Simple and flexible way to build nice URLs for web applications
Alias: pear-URL-Mapper

https://bugzilla.redhat.com/show_bug.cgi?id=431955


fedora at famillecollet.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




------- Additional Comments From fedora at famillecollet.com  2008-02-09 09:17 EST -------
REVIEW:
* rpmlint :
W: no-documentation
* The package is named according to the Package Naming Guidelines.
* The spec file name match the base package
* The package meet the PHP Packaging Guidelines
* Fedora approved license (BSD)
* License field in the package spec file match the actual license
* The spec file is written in American English
* The spec file is legible
* The sources used to build the package must match the upstream source
11a4d002f881ac5d957cdbb6b46139f7  Net_URL_Mapper-0.9.0.tgz
* build in mock (rawhide, noarch)
* All build dependencies are listed in BuildRequires
* no locales
* no shared library files
* package own all directories that it creates
* Package don't own files or directories already owned by other packages
* no duplicate files
* Permissions on files are set properly
* %clean section
* package consistently use macros
* The package contain code
* no documentation
* no library
* no desktop file
* %install, start with rm -rf %{buildroot}
* All filenames are valid UTF-8
* scriptlets are sane
* Final Provides ok
php-pear(Net_URL_Mapper) = 0.9.0
php-pear-Net-URL-Mapper = 0.9.0-1.fc8
**** Final Requires not OK
/usr/bin/pear  
php-pear(Net_URL) >= 1.0.14 (see below)
php-pear(PEAR)  


Must fixe:
   Requires: php-pear(Net-URL) >= 1.0.14
To :
   Requires: php-pear(Net_URL) >= 1.0.14


Should fixe test suite.

Using the attached patch, all provided tests (19+12+22) succeed.

I know running tests during build is not always simple, but it still usefull (as
least an "how to" provided)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.