[Bug 426251] Review Request: tbb - the library that abstracts low-level threading details

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tbb - the library that abstracts low-level threading details


https://bugzilla.redhat.com/show_bug.cgi?id=426251


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-09 11:31 EST -------
For 2.0-2.20070927:

* no-ldconfig-symlink
  - From rpmlint *rpm:
------------------------------------------------------------
tbb.i386: E: no-ldconfig-symlink /usr/lib/libtbbmalloc.so.2.0
tbb.i386: E: no-ldconfig-symlink /usr/lib/libtbb.so.2.0
------------------------------------------------------------
    This is because the symlink name does not match the SONAME
    of the library it points to.
------------------------------------------------------------
$ objdump --headers --private-headers libtbb.so.2.0 | grep SONAME
  SONAME      libtbb_debug.so.2
------------------------------------------------------------
    and this is because from build.log:
------------------------------------------------------------
   100  g++  concurrent_hash_map.o concurrent_queue.o concurrent_vector.o
itt_notify.o cache_aligned_allocator.o pipeline.o queuing_mutex.o
queuing_rw_mutex.o spin_rw_mutex.o spin_mutex.o task.o tbb_misc.o mutex.o   
-lpthread -lrt -ldl  -fPIC -o libtbb_debug.so.2.0.014 -shared -m32
-Wl,-soname=libtbb_debug.so.2
   310  + install -D -m 755 libtbb_debug.so
/var/tmp/tbb-2.0-2.20070927.fc9-root-mockbuild//usr/lib/libtbb.so.2.0
   311  + ln -s libtbb.so.2.0
/var/tmp/tbb-2.0-2.20070927.fc9-root-mockbuild//usr/lib/libtbb.so.2
------------------------------------------------------------
    you have to actually change the soname of the library.

* Compilation flags
  - Fedora specific compilation flags are not correctly honored.
------------------------------------------------------------
    58  make[1]: Entering directory
`/builddir/build/BUILD/tbb20_20070927oss_src/build/obj_debug'
    59  ../../build/Makefile.tbb:38: CONFIG: cfg=debug arch=ia32 compiler=gcc
os=linux runtime=cc4.3.0_libc2.7.90_ker
nel2.6.18
    60  g++  -c -MMD -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-siz
e=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -DTBB_DO_ASSERT
-DDO_ITT_NOTIFY -DUSE_PTHREAD -g -O0
 -m32 -fPIC -Wall -Werror -I../../src/tbb -I../../include -I../../src
../../src/tbb/concurrent_hash_map.cpp
------------------------------------------------------------
     Here the compilation flag "-O2" is replaced by the latter "-O0" flag.

* Timestamps
  - When using "cp" or "install" commands, please add "-p" option
    to keep timestamps on installed files.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.