[Bug 432195] Review Request: disk-manager - Disk manager is a simple filesystem configurator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: disk-manager - Disk manager is a simple filesystem configurator


https://bugzilla.redhat.com/show_bug.cgi?id=432195





------- Additional Comments From wolfy at nobugconsulting.ro  2008-02-10 16:46 EST -------
LGPLv2.1+ is not a correct value for the license tag; according to
http://fedoraproject.org/wiki/Licensing#head-19fc3ef10add085a28cb06784dc34ef8b05a9bd6
the correct value is LGPLv2+

The Categories tag from the desktop file should not contain Application any more
( see http://standards.freedesktop.org/menu-spec/latest/apa.html , referenced by
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755)

Some minor issues: 
- there is no need to included util-linux-ng as BR because it is on the
exceptions list
(http://fedoraproject.org/wiki/Packaging/Guidelines#head-4cadce5e79d38a63cad3941de1dadc9d25d67d30-2)
- duplicate BR: perl(XML::Parser) is brought in by intltool and device-mapper by
e2fsprogs

Everything else seems OK at the first glance






-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.